Skip to content

feat: Migrate PathValid API to use Win32 API to reduce PowerShell overhead #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

feat: Migrate PathValid API to use Win32 API to reduce PowerShell overhead #390

merged 1 commit into from
Jul 3, 2025
+26 −14

Conversation

@laozc
Copy link
Member

@laozc laozc commented Jun 2, 2025 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Migrate the PathValid API to use GetFileAttribute to reduce PowerShell overhead.

Which issue(s) this PR fixes:
Fixes #193

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from ddebroy and gnufied June 2, 2025 03:46
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2025
@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2025
@laozc laozc changed the title feat: Migrate PathExists API to use Win32 API to reduce PowerShell overhead feat: Migrate PathValid API to use Win32 API to reduce PowerShell overhead Jun 21, 2025
@laozc laozc force-pushed the wmi-process-system-api-path-valid branch from cb64885 to 5c6afc6 Compare June 21, 2025 02:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2025
@laozc laozc force-pushed the wmi-process-system-api-path-valid branch from 5c6afc6 to 5be8f0b Compare June 21, 2025 04:53
andyzhangx
andyzhangx approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2025
@laozc laozc force-pushed the wmi-process-system-api-path-valid branch from 5be8f0b to 453133a Compare July 2, 2025 14:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
mauriciopoppe
mauriciopoppe reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@mauriciopoppe mauriciopoppe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please rebase/squash your changes onto a single commit https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits

@laozc laozc force-pushed the wmi-process-system-api-path-valid branch from 453133a to 16813d9 Compare July 2, 2025 23:59
andyzhangx
andyzhangx approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, laozc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 73e19af into kubernetes-csi:master Jul 3, 2025
8 checks passed
@laozc laozc mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauriciopoppe mauriciopoppe mauriciopoppe left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@ddebroy ddebroy Awaiting requested review from ddebroy

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@andyzhangx andyzhangx

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

High cpu usage of powershell processes triggered by csi-proxy

4 participants

@laozc @k8s-ci-robot @andyzhangx @mauriciopoppe